Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit versions #348

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

jameslamb
Copy link
Member

Contributes to #333.

Proposes updating all pre-commit hooks to their latest versions.

My main goal with this is to update to a later version of ruff that has built-in support for IPython notebooks... that's been in since around v0.0.276 last summer: astral-sh/ruff#5188.

Notes for Reviewers

If this PR is merged, I'll add a follow-up configuring ruff to inspect notebook files.

All changes here were made by pre-commit run --all-files, except the changes to source/cloud/azure/index.md. I made those manually, to resolve these new warnings:

source/cloud/azure/index.md:21:167 MD056/table-column-count Table column count [Expected: 9; Actual: 8; Too few cells, row will be missing data]
source/cloud/azure/index.md:22:167 MD056/table-column-count Table column count [Expected: 9; Actual: 8; Too few cells, row will be missing data]
source/cloud/azure/index.md:23:167 MD056/table-column-count Table column count [Expected: 9; Actual: 8; Too few cells, row will be missing data]
source/cloud/azure/index.md:24:167 MD056/table-column-count Table column count [Expected: 9; Actual: 8; Too few cells, row will be missing data]

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 19, 2024
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@jacobtomlinson jacobtomlinson merged commit 77ab5ed into rapidsai:main Apr 9, 2024
3 checks passed
@jameslamb jameslamb deleted the newer-ruff branch April 9, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants