Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference syntax from DLManagedTensor. #15391

Closed
wants to merge 1 commit into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 26, 2024

Description

Fixes a doc build issue caused by DLPack Sphinx changes in dmlc/dlpack#142. This is a workaround to remove the docs reference to DLManagedTensor because it cannot be found.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner March 26, 2024 15:55
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 26, 2024
@bdice bdice added doc Documentation non-breaking Non-breaking change labels Mar 26, 2024
@bdice
Copy link
Contributor Author

bdice commented Mar 26, 2024

The proper fix here is to make DLManagedTensor findable, like :c:struct:`DLManagedTensor` but I don't know how to do that with Doxygen/Breathe, only with normal Sphinx in Python docs. @vyasr Help would be welcome.

@bdice
Copy link
Contributor Author

bdice commented Mar 26, 2024

An alternative workaround would be to add DLManagedTensor to the list of _names_to_skip_in_cpp in docs/cudf/source/conf.py.

@bdice bdice changed the base branch from branch-24.06 to branch-24.04 March 26, 2024 16:01
@vyasr
Copy link
Contributor

vyasr commented Mar 26, 2024

Replaced by #15392

@vyasr vyasr closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants