Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround compute-sanitizer memcheck bug #15259

Merged
merged 5 commits into from Mar 11, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Provides a workaround for the compute-sanitizer issue described in #15258 causing memcheck failures in nightly builds.
An environment variable is introduced LIBCUDF_MEMCHECK_ENABLED so test code can bypass specific tests that cause the compute-sanitizer error. The env var is set only during memcheck tests since the failure does not occur in normal testing.
The failure only occurs for some int16 or uint16 reduction tests so managing these few tests is reasonable.

Other possible workarounds include

  1. Reverting the compute-sanitizer to 11.8
    Using the latest version is more desirable since the fix will likely not be back ported.
  2. Adding an exclude filter to the CUB Reduce kernel
    This disables checking for almost all reduction kernels

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Mar 8, 2024
@davidwendt davidwendt self-assigned this Mar 8, 2024
@github-actions github-actions bot added the ci label Mar 8, 2024
@davidwendt davidwendt marked this pull request as ready for review March 10, 2024 22:52
@davidwendt davidwendt requested review from a team as code owners March 10, 2024 22:52
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a09c215 into rapidsai:branch-24.04 Mar 11, 2024
74 checks passed
@davidwendt davidwendt deleted the sanitizer-workaround branch March 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working ci libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants