Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memcheck error in distinct inner join #15164

Merged

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Feb 28, 2024

Description

Closes #15156
Fixes the invalid global read introduced by #14990 and simplifies the logic.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Feb 28, 2024
@PointKernel PointKernel self-assigned this Feb 28, 2024
@PointKernel PointKernel requested a review from a team as a code owner February 28, 2024 01:37
@hyperbolic2346
Copy link
Contributor

Where is the invalid global read?

@wence-
Copy link
Contributor

wence- commented Feb 28, 2024

Where is the invalid global read?

build_idx = static_cast<cudf::size_type>(found->second);

In the old code was invalid if found == hash_table.end(), but was executed unconditionally.

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit efc4edf into rapidsai:branch-24.04 Feb 29, 2024
76 checks passed
@PointKernel PointKernel deleted the fix-distinct-join-memcheck branch February 29, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memcheck global read error in DistinctJoinTest.IntegerInnerJoin
5 participants