Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically set version in RAPIDS doc builds #15101

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Dynamically set version in RAPIDS doc builds #15101

merged 10 commits into from
Feb 29, 2024

Conversation

jakirkham
Copy link
Member

Following up on issue ( rapidsai/build-planning#15 ), drop RAPIDS version hard-coding in doc builds.

@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 21, 2024
@jakirkham jakirkham requested a review from a team as a code owner February 21, 2024 01:26
@github-actions github-actions bot added the ci label Feb 21, 2024
bdice
bdice previously requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this line as well:

cudf/ci/release/update-version.sh

Line 111 in 4ce99af

sed_runner "s/RAPIDS_VERSION_NUMBER=\".*/RAPIDS_VERSION_NUMBER=\"${NEXT_SHORT_TAG}\"/g" ci/build_docs.sh

Any time a hard-coded version is adjusted, the update-version.sh script should be checked.

@jakirkham jakirkham requested a review from bdice February 22, 2024 23:57
@vyasr
Copy link
Contributor

vyasr commented Feb 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1a3b789 into rapidsai:branch-24.04 Feb 29, 2024
76 checks passed
@jakirkham jakirkham deleted the use_rgv_docs branch February 29, 2024 19:28
@ajschmidt8
Copy link
Member

This broke our docs uploads. rapids-generate-version generates strings like 24.04.00a476, which is different from the original 24.04 string that was hardcoded.

Our documentation bucket now contains a list of folders that looks like this:

23.02
23.04
23.06
23.08
23.10
23.12
24.02
24.04.00a476
24.04.00a485
24.04.00a486
24.04.00a488
24.04.00a489
24.04.00a491
24.04.00a493
24.04.00a502
24.04.00a503
24.04.00a504
24.04.00a506
24.04.00a508
24.04.00a512
24.04.00a513
24.04.00a516
24.04.00a519
24.04.00a524
24.04.00a526
24.04.00a530
24.04.00a531
24.04.00a532
24.04.00a533
24.04.00a543
24.04.00a544
24.04.00a546
24.04.00a550
24.04.00a551
24.04.00a553
24.04.00a554
24.04.00a558
24.04.00a559
24.04

cc: @raydouglass

@bdice bdice mentioned this pull request Mar 13, 2024
Closed
3 tasks
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Mar 13, 2024
Merged
3 tasks
@jakirkham
Copy link
Member Author

Thanks AJ! 🙏

Addressing with PR: #15291

rapids-bot bot pushed a commit that referenced this pull request Mar 13, 2024
@KyleFromNVIDIA
Fix Doxygen upload directory (#15291)
1ac1b2d 
Prompted by #15101 (comment)

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - https://github.com/jakirkham

URL: #15291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raydouglass raydouglass raydouglass approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jakirkham @vyasr @ajschmidt8 @raydouglass @bdice