Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for
pandas-2.2
incudf
#15100Add support for
pandas-2.2
incudf
#15100Changes from 21 commits
5262a4e
1e77124
32c1c0f
6daba82
00f1bbe
f42676d
a6c78ec
ec80e9a
2c00c59
04309a6
d15323a
7fcc521
7da7100
82b0644
391b602
1b8a1e5
ecd9221
fa72dd8
65c8652
07d57f6
adcd271
3efb4f8
cae3b0d
ffa1edc
d50ed04
415de9b
ca9933d
340a4de
65bba60
a926ad1
328bc95
4f76e9f
62cf147
fb8924b
8159ac2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right pinning, or should we go with
<2.3.0dev0
? Do we expect patch releases to break us?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel various fixes are going into
2.2.1
that may have an impact on us, but would defer to @mroeschke on that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I fixed various issues @galipremsagar found in pandas 2.2.1 (coming out next week) which there are xfails for so the update will break the test suite. We should probably relax the pin in a follow up PR when that's out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we sort these, so we have all the
EQ
thenGE
thenLT
? It looks like you deleted a duplicate line but it ended up breaking up the groupings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I'll do that in a follow-up pr. Potentially there is still some cleanup to be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in noting in the future we should pass pandas a numpy array instead of a pyarrow array and
pandas.Series
treats pyarrow arrays as objects