Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change is_.._dtype deprecations to DeprecationWarning instead of FutureWarning #14617

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Change is_.._dtype deprecations to DeprecationWarning instead of FutureWarning #14617

merged 2 commits into from
Dec 18, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Dec 12, 2023 •
edited

Description

This PR changes all FutureWarning's to DeprecationWarning's to match with pandas: pandas-dev/pandas#55703

On pandas_2.0_feature_branch:

= 501 failed, 101106 passed, 2071 skipped, 786 xfailed, 312 xpassed, 20 errors in 1234.91s (0:20:34) =

This PR:

= 445 failed, 101162 passed, 2071 skipped, 786 xfailed, 312 xpassed, 20 errors in 1216.79s (0:20:16) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team cuDF (Python) Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 12, 2023
@galipremsagar galipremsagar self-assigned this Dec 12, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner December 12, 2023 18:07
@galipremsagar galipremsagar requested review from isVoid, charlesbluca, mroeschke and vyasr and removed request for a team December 12, 2023 18:07
vyasr
vyasr requested changes Dec 12, 2023
View reviewed changes
.pre-commit-config.yaml Show resolved Hide resolved
@galipremsagar galipremsagar mentioned this pull request Dec 12, 2023
Closed
@galipremsagar galipremsagar merged commit bc5584b into rapidsai:pandas_2.0_feature_branch Dec 18, 2023
19 of 22 checks passed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@wence- wence- Awaiting requested review from wence-

@vyasr vyasr Awaiting requested review from vyasr

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuDF (Python) Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@galipremsagar @vyasr @mroeschke