Deprecate fill_method and limit in pct_change APIs
#14277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
galipremsagar
requested review from
bdice and
isVoid
and removed request for
a team
mroeschke
reviewed
Oct 13, 2023
mroeschke
reviewed
Nov 29, 2023
| @@ -2298,9 +2304,15 @@ def pct_change( | |||
| Periods to shift for forming percent change. | |||
| fill_method : str, default 'ffill' | |||
| How to handle NAs before computing percent changes. | |||
|
|
|||
| .. deprecated:: 23.12 | |||
There was a problem hiding this comment.
So recently, supported was added back for fill_method=None which means "don't fill the NA values" pandas-dev/pandas#55527
There was a problem hiding this comment.
Done, updated 👍
mroeschke
reviewed
Nov 29, 2023
| FutureWarning, | ||
| ) | ||
|
|
||
| if fill_method in (no_default, None): |
There was a problem hiding this comment.
I think I would expect to skip the fillna step if fill_method=None
There was a problem hiding this comment.
Pandas appears to deviate in this case: https://github.com/pandas-dev/pandas/blob/v2.1.3/pandas/core/groupby/groupby.py#L5317
There was a problem hiding this comment.
Ah interesting. OK yeah best to match pandas here then
mroeschke
approved these changes
Nov 29, 2023
galipremsagar
merged commit 90788f2
into
rapidsai:pandas_2.0_feature_branch
18 of 20 checks passed
galipremsagar
added
the
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecated
fill_methodandlimitinSeries.pct_change,DataFrame.pct_changeandGroupby.pct_changeThis PR:
On
pandas_2.0_feature_branch:Checklist