Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error on import for unsupported GPUs. #15053

Merged
merged 1 commit into from Feb 23, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 14, 2024

Description

RAPIDS 24.02 dropped support for Pascal GPUs. When using an unsupported GPU, the behavior of cudf is undefined and sometimes produces results that appear valid (and empty) but conceal CUDA kernel launch errors. This PR changes the behavior to error on import if unsupported GPUs are detected.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added bug Something isn't working breaking Breaking change labels Feb 14, 2024
@bdice bdice self-assigned this Feb 14, 2024
@bdice bdice requested a review from a team as a code owner February 14, 2024 16:36
@github-actions github-actions bot added the cuDF (Python) Affects Python cuDF API. label Feb 14, 2024
@bdice
Copy link
Contributor Author

bdice commented Feb 14, 2024

I tested this locally. If you run on a Pascal (unsupported) GPU, you get:

cudf.errors.UnsupportedCUDAError: A GPU with NVIDIA Volta™ (Compute Capability 7.0) or newer architecture is required.
Detected GPU 0: Tesla P100-SXM2-16GB

Detected Compute Capability: 6.0

If you run on a CPU-only machine, or set CUDA_VISIBLE_DEVICES="" on a machine with GPUs (supported or not), you get UserWarning: No NVIDIA GPU detected.

If users need to run on a Pascal machine as-if it is a CPU-only machine, setting CUDA_VISIBLE_DEVICES="" is a sufficient workaround.

@bdice bdice requested a review from shwina February 14, 2024 17:41
@bdice
Copy link
Contributor Author

bdice commented Feb 14, 2024

@shwina Please see comment above and merge if you're good with that behavior.

@shwina
Copy link
Contributor

shwina commented Feb 23, 2024

I'll note here that RAPIDS_NO_INITIALIZE=1 is another way to circumvent this check if needed.

@shwina
Copy link
Contributor

shwina commented Feb 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit c84e1e8 into rapidsai:branch-24.04 Feb 23, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working cuDF (Python) Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants