Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up extension creator - add rancher annotations to pkg.package.json #12741

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Dec 2, 2024

Summary

Fixes #12094

Ties up a few loose ends with the extension creator:

  • Moved the rancher annotations to the correct package.json file for extension packages
  • Removed unnecessary dependencies from the pkg.package.json template and pkg creator package.json
  • Removed chart.yaml annotations for extension helm chart.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
flaeppe Petter Friberg
Remove annotations from helm chart
@jordojordo jordojordo added the creator PRs/Issues that relate to a creator release rather than being needed for a dashboard release label Dec 2, 2024
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordojordo jordojordo merged commit 5fe5004 into rancher:master Dec 3, 2024
32 checks passed
@jordojordo jordojordo deleted the creator-fixes branch December 3, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions creator PRs/Issues that relate to a creator release rather than being needed for a dashboard release QA/None
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions catalog build will add unnecessary default annotations
2 participants