Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension creator upgrade paths - Update documentation #12737

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

jordojordo
Copy link
Member

@jordojordo jordojordo commented Dec 2, 2024

Summary

Fixes #12035
Fixes #12036

This will re-implement the update script for extensions using the --update option. It allows extension developers to upgrade their extensions from legacy-v1, to legacy-v2.

Occurred changes and/or fixed issues

  • Switched execSync calls in the main creator script to spawnSync to pass arguments as an array
  • Fixed an issue with the upgrade.sh script not being called due to a typo
  • Updated documentation to include information on how to build/create an extension for different Rancher versions, as well as how to upgrade to be compatible with a newer version of Rancher

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
flaeppe Petter Friberg

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mate!

@jordojordo jordojordo merged commit f045877 into rancher:master Dec 2, 2024
40 checks passed
@jordojordo jordojordo deleted the creators-update-paths branch December 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants