Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable extension checks for elemental and kubewarden in test-plugins-build #12597

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Nov 13, 2024

Summary

Fixes #12026
Fixes #10995

  • re-enable extension checks for elemental and kubewarden in test-plugins-build script since both projects have valid vue3 extensions in main and builds should work just fine
  • adds extension check for neuvector extension

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sorry, something went wrong.

@aalves08 aalves08 requested a review from cnotv November 13, 2024 16:31
@aalves08 aalves08 self-assigned this Nov 13, 2024
@aalves08 aalves08 added this to the v2.10.1 milestone Nov 13, 2024

Verified

This commit was signed with the committer’s verified signature.
flaeppe Petter Friberg
…ns-build

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@aalves08 aalves08 force-pushed the 12026-re-enable-checks-extensions branch from 372b09b to 1464a04 Compare November 14, 2024 16:08
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 783ba1f into rancher:master Nov 14, 2024
31 checks passed
@aalves08 aalves08 deleted the 12026-re-enable-checks-extensions branch November 14, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants