Fix use of deprecated set-output command
#238
Merged
+420
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set-output` has been deprecated. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.
Bash gets confused with the variable being named `command`.
... and make them slightly more descriptive.
Follow up to 237 which updated the `composer.phar` file, but missed the update needed to the test expectations.
Note: there may well be a way to not have the regex inline, which would make the code more readable, but I'm not familiar enough with Tcl and to be honest, I'm already darn glad that I managed to get it working ;-) Refs: * https://www.tcl.tk/man/tcl8.5/TclCmd/regexp.html * https://www.tcl.tk/man/tcl8.5/TclCmd/re_syntax.html
|
@ramsey Might be helpful for other contributors to include the links to the Tcl manual and the online testing tool in the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v2 #238 +/- ##
==========================================
- Coverage 98.29% 97.45% -0.84%
==========================================
Files 5 5
Lines 117 118 +1
==========================================
Hits 115 115
- Misses 2 3 +1
|
|
Thanks, @jrfnl ! |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per #235:
Fixes #236
Closes #235
Motivation and context
How has this been tested?
This has been tested on the one hand by actually running the tests and on the other hand, by verifying the syntax used in the additional adjustments I made via https://rextester.com/l/tcl_online_compiler
Types of changes
PR checklist
👉🏻 I don't think so, but as per the discussion here First pass at removing
set-output#235 (comment), the name of one of the (internal) outputs has changed fromcommandtocomposer_command, but that output may possibly be exposed the action.If that's the case, this would need a changelog entry just in case anyone would be directly grabbing the output and re-using it in their workflow.
Commit info
.. for the commits added on top of the original PR #235:
composer_paths.sh: fix issue flagged by shellcheck
Ref: https://www.shellcheck.net/wiki/SC2129
Tests: fix inline comments
... and make them slightly more descriptive.
Tests/composer_paths_09.exp: fix expectation
Follow up to #237 which updated the
composer.pharfile, but missed the update needed to the test expectations.Tests: fix test which need a pattern match
Note: there may well be a way to not have the regex inline, which would make the code more readable, but I'm not familiar enough with Tcl and to be honest, I'm already darn glad that I managed to get it working ;-)
Refs: