Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the -encoding argument optionally to java compiler #157

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Add the -encoding argument optionally to java compiler #157

merged 1 commit into from
Sep 19, 2019

Conversation

krypton
Copy link

@krypton krypton commented Sep 19, 2019

Add the possibility to specify the -encoding argument do javac command.

This is useful for when you have multiple projects to compile and each one have different encodings on class files.

I know that we can set the JAVA_TOOL_OPTIONS env variable like this ENV['JAVA_TOOL_OPTIONS'] = '-Dfile.encoding=windows-1252' but if we do this it's gone affect all the JavaExtensionTask that we have defined to run.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kou kou merged commit b4b390c into rake-compiler:master Sep 19, 2019
@kou
Copy link
Member

kou commented Sep 19, 2019

Thanks!

@krypton krypton deleted the javac-encoding-option branch September 20, 2019 07:26
@krypton
Copy link
Author

krypton commented Sep 20, 2019

@kou are you gonna publish this version to RubyGems?

@kou
Copy link
Member

kou commented Sep 20, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants