Add support for nested exceptions #265
Merged
+80
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on rails/rails#32410.
This PR adds support for nested exceptions that is being discussed in the upstream Rails. The idea is to add an object scope using the
exception_object_id
and pass it to the web console session along with theframe_id
, so the session will be able to switch the binding to the specified frame in the appropriate exception.Obviously, there needs to be some test overage around this as this is touching the core functionality of the gem. But please let me know if there is any feedback.