Add support for printing tables with borders #855
Merged
+90
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
features/print-table-with-borders
branch
2 times, most recently
from
5839dad to
f8d24ca
Compare
p8
force-pushed
the
features/print-table-with-borders
branch
2 times, most recently
from
8890ecf to
74ca5b9
Compare
Adding borders to tables can improve their legibility. This would allow replacing the custom table for code statistics in Rails, with the generic implementation in Thor. By adding :separators to a table a horizontal separator will be added. This functionality was inspired by: https://github.com/piotrmurach/tty-table
p8
force-pushed
the
features/print-table-with-borders
branch
from
74ca5b9 to
aab2c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding borders to tables can improve their legibility.
Before
After with
borders: trueThis would allow replacing the custom table for code statistics in
Rails, with the generic implementation in Thor.
By adding :separators to a table a horizontal separator will be added.
This functionality was inspired by: https://github.com/piotrmurach/tty-table
Having the ability to add separators where required adds more flexibility instead of having headers and footers.
Builds on: #854