CreateFile#identical? fixed for files containing multi-byte UTF-8 codepoints #786
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
reviewed
May 18, 2022
| @@ -43,7 +43,7 @@ def initialize(base, destination, data, config = {}) | |||
| # Boolean:: true if it is identical, false otherwise. | |||
| # | |||
| def identical? | |||
| exists? && File.binread(destination) == render | |||
| exists? && File.binread(destination) == String.new(render).force_encoding("ASCII-8BIT") | |||
There was a problem hiding this comment.
I'd add a comment here indicating that binread defaults to this encoding to explain why this works.
…comparing created files
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
Currently if you regenerate a file that contains a multi-byte UTF-8 codepoint (such as €) the file will falsely be identified as having changed. This PR adds a test to the create_file_spec to identify the problem, and then fixes the problem.
The change is the same as in #656, but that PR seems to have languished unmerged for just over 3yrs. I'm hoping the testing approach in the PR will address the previous objections so that the change can be merged.