Specify an explicit external encoding for tests #392
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system, I have set my
LC_ALL
environment variable toC
, because it speeds up a lot of common Unix commands when you're dealing with ASCII-only input.This causes Ruby to use
US-ASCII
as the default external encoding, which triggers a failure in the Thor specs:Changing
Encoding.default_external
globally in the spec helper is the most straightforward fix, but there are a lot of other possible ways to fix this, particularly by specifying an explicit encoding for theStringIO
object created in thecapture
helper. Let me know if you'd like me to resubmit with a different solution.