Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class name in sample code #751

Merged
merged 1 commit into from Aug 5, 2022
Merged

Fix class name in sample code #751

merged 1 commit into from Aug 5, 2022

Conversation

ursm
Copy link
Contributor

@ursm ursm commented Jul 24, 2022

Sprockets::Exporters::Zlip does not seem to exist.

Copy link
Member

@p8 p8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me as the register_exporter sample code uses ZlibExporter as well:

# register_exporter '*/*', Sprockets::Exporters::ZlibExporter

I don't think we need to add documentation changes to the CHANGELOG.

@ursm
Copy link
Contributor Author

ursm commented Aug 5, 2022

I don't think we need to add documentation changes to the CHANGELOG.

Got it, I deleted that commit.

@p8
Copy link
Member

p8 commented Aug 5, 2022

Thanks @ursm !

@p8 p8 merged commit 8ffcbdd into rails:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants