Fix cache key for coffee script processor #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without that fix there was a strange bug in our codebase. When Rails tried to That was because there is also an empty file |
The current implementation leads to a problem with the generation of the sourcemap. Two files with a different name but the same content (e.g. empty files) have different sourcemaps. But the current implementation returns the v3SourceMap of the first file for every subsequent call from the cache. So the commit changes the cache key to be dependent on the filename.
|
@rafaelfranca sorry for add another thing to your inbox, but short question: Is there anything we can provide you with to get this PR merged? |
|
This looks like the same bug that was already fixed for the Babel Processor 6 years ago: 0bc6763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation leads to a problem with the generation of the sourcemap. Two files with a different name but the same content (e.g. empty files) have different sourcemaps. But the current implementation returns the v3SourceMap of the first file for every subsequent call from the cache. So the commit changes the cache key to be dependent on the filename.