More restore original db config in db rake tasks #51862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on test failures. Next time I'll run more tests before opening a pull. |
justinko
commented
May 20, 2024
| end | ||
|
|
||
| def with_stubbed_temporary_connection(&block) | ||
| ActiveRecord::Tasks::DatabaseTasks.stub(:with_temporary_connection, ->(*, &block) { block.call }, &block) |
There was a problem hiding this comment.
Just passes through with no asserting -- didn't think it was important since the logic doesn't pertain to it.
I did build a version with some asserting (the configs are passed to it) so if that's what we want ... I can swap it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51830
Motivation / Background
This is just additional changes that would've been included in #46270
Detail
When running multiple db rake tasks in a single command, we should restore to the original "db config" in between each task.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]