Don’t configure Kamal storage volume if not needed #51838
Merged
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you add a test to make sure this option works as expected? I think some tests at https://github.com/rails/rails/blob/main/railties/test/generators/app_generator_test.rb are helpful as a reference. |
jeromedalbert
force-pushed
the
no-kamal-storage-volume-if-not-needed
branch
from
2f089cb
to
dccb36f
Compare
|
@yahonda Done, thanks for the pointer! |
yahonda
reviewed
May 17, 2024
railties/lib/rails/generators/rails/app/templates/config/deploy.yml.tt
Outdated
Show resolved
Hide resolved
jeromedalbert
force-pushed
the
no-kamal-storage-volume-if-not-needed
branch
from
dccb36f
to
bc220cd
Compare
zzak
reviewed
May 18, 2024
jeromedalbert
force-pushed
the
no-kamal-storage-volume-if-not-needed
branch
2 times, most recently
from
824a875
to
2db1d4c
Compare
Configuring a persistent storage volume in Kamal is needed only for sqlite or Active Storage. If using a different database or the --skip-active-storage option, this configuration can be skipped.
jeromedalbert
force-pushed
the
no-kamal-storage-volume-if-not-needed
branch
from
2db1d4c
to
3156e50
Compare
|
It seems like the buildkite failed docs-preview job is unrelated. |
yahonda
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #51836.
This Pull Request has been created because configuring a Docker persistent storage volume in Kamal seems to be only needed for sqlite or Active Storage. If using a different database and the
--skip-active-storageoption, configuration can be skipped.Detail
This Pull Request changes the
config/deploy.yml.tttemplate to skip persistent storage volume configuration if skipping Active Storage and using a database that is different from sqlite.Additional information
The condition I implemented is the same as the one used here in the rails app generator.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]