-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment
and table_comment
table schema definition
#51661
base: main
Are you sure you want to change the base?
Add comment
and table_comment
table schema definition
#51661
Conversation
May be |
81b37be
to
93bb278
Compare
Hello @rafaelfranca I see you merged similar commit Please review my PR as well. Thank you |
93bb278
to
817ee08
Compare
I don't think this is the same as |
Hello @zzak. Thank you for your reply. Currently in the abstract adapter there are exceptions when comments are not supported and specific methods for PostgreSQL and MySQL 1, 2 adapters Maybe you have some idea how to improve PR changes? |
741532c
to
f9ec6b7
Compare
change_column_comment
and change_table_comment
table schema definitioncomment
and table_comment
table schema definition
I've added condition for tests (only for adapters that support comments). As for the @zzak could you look at the PR? |
9b23b52
to
ea52b4c
Compare
2f5ab2d
to
1310419
Compare
1310419
to
c75095d
Compare
Motivation / Background
This Pull Request has been created because these methods are missing, but could be helpful for bulk changes of the table. This will allow you to add comment(s) to the table and/or to the column(s) using single block, improving readability and performance because of single query
Detail
This Pull Request adds
comment
andtable_comment
forchange_table
definitionAdditional information
This was intended as non-breaking change
Checklist
[Fix #issue-number]