Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-word #49856 CHANGELOG entry [ci skip] #50752

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Re-word #49856 CHANGELOG entry [ci skip] #50752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion actionview/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@

*Sean Doyle*

* Rename `ActionView::TestCase::Behavior::{Content,RenderedViewContent}`
* Rename `ActionView::TestCase::Behavior::Content` to `ActionView::TestCase::Behavior::RenderedViewContent`

Make `RenderedViewContent` inherit from `String`. Make private API with `:nodoc:`
Copy link
Member

@p8 p8 Jan 15, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this line is a bit unclear to me. What is made private API?
Maybe something like:

Suggested change
Make `RenderedViewContent` inherit from `String`. Make private API with `:nodoc:`
`RenderedViewContent` is explicitly made private API and inherits from `String`
instead of SimpleDelegator.


*Sean Doyle*

Expand Down