Enable Minitest/NonExecutableTestMethod cop
#50379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
yahonda
force-pushed
the
enable_minitest_non_executable_test_method_cop
branch
from
559b89d
to
dbd4669
Compare
|
Let me take a look at two offenses detected at https://github.com/rails/rails/actions/runs/7237053923/job/19716256259?pr=50379 |
|
JFYI, #50515 has been merged. |
This pull request enables `Minitest/NonExecutableTestMethod` cop to find non-executed test that is out of `ActiveSupport::TestCase` and its subclasses. This cop is based on the request since there was a test that is not executed found at rails#50334 (comment) and implemented to RuboCop Minitest 0.34.0 via rubocop/rubocop-minitest#279 This cop works as follows. As of right now, there is no offenses by reverting the merge commit via rails#50334 ``` $ git revert -m 1 9517841 $ bundle exec rubocop Inspecting 3254 files ... snip ... Offenses: activerecord/test/cases/assertions/query_assertions_test.rb:27:5: W: Minitest/NonExecutableTestMethod: Test method should be defined inside a test class to ensure execution. def test_assert_no_queries ... ^^^^^^^^^^^^^^^^^^^^^^^^^^ 3254 files inspected, 1 offense detected $ ``` * `Gemfile.lock` has been updated as follows ``` bundle update rubocop rubocop-minitest --conservative ```
rafaelfranca
force-pushed
the
enable_minitest_non_executable_test_method_cop
branch
from
dbd4669
to
6384eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This pull request enables
Minitest/NonExecutableTestMethodcop to find non-executed test that is out ofActiveSupport::TestCaseand its subclasses.This cop is based on the request since there was a test that is not executed found at #50334 (comment) and implemented to RuboCop Minitest 0.34.0 via rubocop/rubocop-minitest#279
Detail
This cop works as follows.
As of right now, there is no offenses by reverting the merge commit via #50334
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]