Default gemfile generator to puma >= 6.0 #49825
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puma 5.x is not compatible with Rack 3 cookies. The current default new Gemfile uses puma ">= 5.0". Puma ~> 5.6 will error on start when used with Rack 3, but earlier versions will not.
puma/puma#3164: Support Rack 3 cookies
puma/puma#3166: Prevent loading with rack 3
phusion/passenger#2503: Related passenger issue detailing cookie error
Motivation / Background
This Pull Request has been created because new Rails apps can install versions of Puma which will silently set cookies incorrectly if used with rack 3.x
Detail
This Pull Request changes the base generator to default to puma >= 6.0
Additional information
Based on puma/puma#3164, would it make sense to backport this back to Rails 6.1?
/cc @JoeDupuis as original author on the puma side
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]