Re-word #49856 CHANGELOG entry [ci skip] #50752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to [rails#49856][] Replace shell word expansion with full English. In addition to that change, elaborate on the changes with more detailed explanation. [rails#49856]: rails#49856 (comment)
4 tasks
seanpdoyle
changed the title
|
Thank you! |
p8
reviewed
Jan 15, 2024
| * Rename `ActionView::TestCase::Behavior::{Content,RenderedViewContent}` | ||
| * Rename `ActionView::TestCase::Behavior::Content` to `ActionView::TestCase::Behavior::RenderedViewContent` | ||
|
|
||
| Make `RenderedViewContent` inherit from `String`. Make private API with `:nodoc:` |
There was a problem hiding this comment.
Hmm, this line is a bit unclear to me. What is made private API?
Maybe something like:
Suggested change
| Make `RenderedViewContent` inherit from `String`. Make private API with `:nodoc:` | |
| `RenderedViewContent` is explicitly made private API and inherits from `String` | |
| instead of SimpleDelegator. |
rafaelfranca
pushed a commit
that referenced
this pull request
Jan 15, 2024
Re-word #49856 CHANGELOG entry [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #49856
Replace shell word expansion with full English. In addition to that change, elaborate on the changes with more detailed explanation.