Fix ActiveSupport::Inflector.humanize(nil)
#48800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinjam
added a commit
to alphagov/content-data-admin
that referenced
this pull request
Jul 25, 2023
`humanize(nil)` currently raises ``NoMethodError: undefined method `end_with?' for nil:NilClass`` due to a regression in Rails 7.0.6 (see rails/rails#48800)
byroot
added a commit
that referenced
this pull request
Jul 25, 2023
Fix `ActiveSupport::Inflector.humanize(nil)`
|
Thanks. Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes a regression introduced in #48348.
In activesupport v7.0.5.1,
ActiveSupport::Inflector.humanize(nil)returned"".In activesupport v7.0.6, it raises
NoMethodError: undefined method `end_with?' for nil:NilClass.Detail
This PR adds a regression test to surface the issue, and restores the original behaviour.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]