Merge pull request #48800 from robinjam/fix-humanize-nil

Fix `ActiveSupport::Inflector.humanize(nil)`
rails · Jul 25, 2023 · b18b9df · b18b9df
1 parent 2fde2bd
commit b18b9df
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md
@@ -1,3 +1,7 @@
+*   Fix `ActiveSupport::Inflector.humanize(nil)` raising ``NoMethodError: undefined method `end_with?' for nil:NilClass``.
+
+    *James Robinson*
+
 *   Fix `Enumerable#sum` for `Enumerator#lazy`.
 
     *fatkodima*, *Matthew Draper*, *Jonathan Hefner*

diff --git a/activesupport/lib/active_support/inflector/methods.rb b/activesupport/lib/active_support/inflector/methods.rb
@@ -136,7 +136,7 @@ def humanize(lower_case_and_underscored_word, capitalize: true, keep_id_suffix:
 
       result.tr!("_", " ")
       result.lstrip!
-      if !keep_id_suffix && lower_case_and_underscored_word.end_with?("_id")
+      if !keep_id_suffix && lower_case_and_underscored_word&.end_with?("_id")
         result.delete_suffix!(" id")
       end
 

diff --git a/activesupport/test/inflector_test.rb b/activesupport/test/inflector_test.rb
@@ -370,6 +370,10 @@ def test_humanize
     end
   end
 
+  def test_humanize_nil
+    assert_equal("", ActiveSupport::Inflector.humanize(nil))
+  end
+
   def test_humanize_without_capitalize
     UnderscoreToHumanWithoutCapitalize.each do |underscore, human|
       assert_equal(human, ActiveSupport::Inflector.humanize(underscore, capitalize: false))