Suggestion: Return early from collection partial rendering if blank. #560
+36
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was messing around with making a project's Jbuilder renders more efficient the other day.
I noticed that even empty collections trigger partial renders and take milliseconds for each, although they end up just returning
[]
. For the examples below (pulled from the README):Originally, I had written a little helper method in our project to optionally include the
{ partial:, as: }
hash to thejson.comments(@post.comments)
call, but that seemed cumbersome to include everywhere and I wondered why this wasn't somehow handled inJbuilder
code.I just started messing around locally and found that this seems to take care of it, but figured I'd open a discussion and see what others think, since I'm extremely knew to Jbuilder and could be missing something obvious.
Screenshots (Console Output Differences)