Merge pull request #117 from eregon/fix-symbol-conversion

Convert Symbol explicitly to a JS String and add test
rails · Jul 19, 2022 · e553b3f · e553b3f
2 parents 82dbb78 + 9e0855d
commit e553b3f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/execjs/graaljs_runtime.rb b/lib/execjs/graaljs_runtime.rb
@@ -98,10 +98,8 @@ def convert_ruby_to_js(value)
         case value
         when nil, true, false, Integer, Float
           value
-        when String
+        when String, Symbol
           Truffle::Interop.as_truffle_string value
-        when Symbol
-          value.to_s
         when Array
           value.map { |e| convert_ruby_to_js(e) }
         when Hash

diff --git a/test/test_execjs.rb b/test/test_execjs.rb
@@ -172,6 +172,9 @@ def test_symbol
     assert_equal "symbol", context.call("echo", :symbol)
     assert_equal ["symbol"], context.call("echo", [:symbol])
     assert_equal({"key" => "value"}, context.call("echo", {key: :value}))
+
+    context = ExecJS.compile("function myslice(str) { return str.slice(1); }")
+    assert_equal "ymbol", context.call("myslice", :symbol)
   end
 
   def test_additional_options