Fix content-length calcuation in Rack:Response#write #2150
Merged
+32
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
commented
Jan 30, 2024
mattbrictson
force-pushed
the
fix-content-length
branch
from
bc337da
to
9b6a823
Compare
|
The jruby CI failures seem unrelated? |
ioquatix
approved these changes
Jan 30, 2024
When `Rack::Response` is initialized with an Array, it incorrectly increments its internal `@length` value and emitted content-length header on every subsequent write. The more times `write` is called, the more the error accumulates. This commit fixes the accumulation bug, and fixes/adds specs to properly test the scenario where `write` is used multiple times.
mattbrictson
force-pushed
the
fix-content-length
branch
from
578243c
to
3f7075b
Compare
|
Thanks for your contribution. @jeremyevans as this is a bug fix should we consider back porting to 3.0? |
|
Sure, this seems reasonable to backport. |
ioquatix
pushed a commit
that referenced
this pull request
Jan 31, 2024
When `Rack::Response` is initialized with an Array, it incorrectly increments its internal `@length` value and emitted content-length header on every subsequent write. The more times `write` is called, the more the error accumulates. This commit fixes the accumulation bug, and fixes/adds specs to properly test the scenario where `write` is used multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Rack::Responseis initialized with an Array, it properly sets its internal@lengthvalue and emitted content-length header on the first use ofwrite. But every subsequent timewriteis called, it increments the length incorrectly, resulting in an incorrect content-length header.This commit fixes the accumulation bug, and fixes/adds specs to properly test the scenario where
writeis used multiple times.Fixes #2148