Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.8 #2140

Closed
wants to merge 3 commits into from
Closed

2.2.8 #2140

wants to merge 3 commits into from

Conversation

majioa
Copy link

@majioa majioa commented Dec 31, 2023

  • fixed by backporting mocking rack request
  • fixed rack response if buffered response isn't array

mikegee
mikegee reviewed Jan 1, 2024
View reviewed changes
lib/rack/mock.rb Outdated Show resolved Hide resolved
majioa and others added 3 commits March 21, 2024 09:21
@majioa @ioquatix
fix: buffered response isn't array
a9ba65c
@majioa @ioquatix
fix: rack mock
47289f9 
! backport for fixed rack mock
@ioquatix @mikegee
Fix whitespace.
a5e98dc 
Co-authored-by: Michael Gee <michaelpgee@gmail.com>
@ioquatix
Copy link
Member

Hello, do you mind clarifying what you are trying to fix here?

@jeremyevans
Copy link
Contributor

We should close this, none of the requested backport commits are security related.

@ioquatix ioquatix closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikegee mikegee mikegee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@majioa @ioquatix @jeremyevans @mikegee