Better error handling in MockRequest.env_for w.r.t. input encodings.
#2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
mockrequest-input-stringio-encoding
branch
from
2e1499a
to
3d13b77
Compare
tenderlove
reviewed
Aug 28, 2023
ioquatix
force-pushed
the
mockrequest-input-stringio-encoding
branch
from
0a76d3d
to
72e951b
Compare
ioquatix
changed the title
set_encoding when we wrap a string.MockRequest.env_for w.r.t. input encodings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would try to invoke
#set_encodingon all input bodies. Let's be more specific and issue more valuable errors when dealing with non-binary input bodies.Fixes #2115.
See also #2116.