Support underscore in host names for Rack 2.2 (Fixes #2070) #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes Rack 2.2 behavior similar to Rack 2.1 and Rack 3.0 in regards to underscore in host names.
ioquatix
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
This seems okay to me for consistency.
The current Rack 3 implementation for reference:
Lines 703 to 714 in f5666bc
|
@jeremyevans do we need to add tests to Rack main? |
|
I think it would be a good idea. |
|
If you have time, can you make a follow-up PR. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 2, 2023
https://build.opensuse.org/request/show/1090442 by user dancermak + dimstar_suse - update to version 2.2.7 * Correct the year number in the changelog (rack/rack#2015) * Support underscore in host names for Rack 2.2 (rack/rack#2071) (forwarded request 1084068 from krauselukas)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Rack 2.2 behavior similar to Rack 2.1 and Rack 3.0 in regards to underscore in host names.