Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make query parameters without = have nil values #2059

Merged
merged 5 commits into from Mar 16, 2023
Merged

Make query parameters without = have nil values #2059

merged 5 commits into from Mar 16, 2023
+64 −297

Commits on Mar 16, 2023

  1. Revert "Prefer to use query_parser itself as the cache key. (rack#2058 

    )"

This reverts commit 5f90c33.
    @jeremyevans
    jeremyevans committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    61d5957 View commit details
    Browse the repository at this point in the history

  2. Revert "Fix handling of cached values in Rack::Request. (rack#2054)" 

    This reverts commit d25fedd.
    @jeremyevans
    jeremyevans committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    77f3334 View commit details
    Browse the repository at this point in the history

  3. Revert "Add QueryParser#missing_value for handling missing values +… 

    … tests. (rack#2052)"

This reverts commit 59d9ba9.
    @jeremyevans
    jeremyevans committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    be3ea6e View commit details
    Browse the repository at this point in the history

  4. Revert "Split form/query parsing into two steps (rack#2038)" 

    This reverts commit 9f059d1.
    @jeremyevans
    jeremyevans committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0827e96 View commit details
    Browse the repository at this point in the history

  5. Make query parameters without = have nil values 

    This was Rack's historical behavior.  While it doesn't match
URL spec section 5.1.3.3, keeping the historical behavior avoids
all of the complexity required to support the URL spec standard
by default, but also support frameworks that want to be backwards
compatible.

This keeps as much of the specs added by the recently reverted
commits that make sense.
    @jeremyevans
    jeremyevans committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    8beebd3 View commit details
    Browse the repository at this point in the history