New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make env['rack.input']
optional.
#2018
Conversation
ec67f1b
to
9c4360c
Compare
Ignore the failures in 2.5, it's done this before and seems an issue with rubygems/bundler/ruby-setup AFAICT. |
636567b
to
271699d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be OK once the the Ruby 2.4/2.5 CI removal is no longer included. I fixed the CI tests for Ruby 2.5 in #2021.
@ioquatix Can you remove the first commit and then rebase on master? Then this should be good to merge. |
271699d
to
3a7a8ba
Compare
Okay done. |
3a7a8ba
to
46f67a2
Compare
46f67a2
to
c993a37
Compare
Fixes #1994. Fixes #1995.