Skip to content

Commit

Permalink
Prefer Rack::ErrorHandler middleware.
Browse files Browse the repository at this point in the history
  • Loading branch information
ioquatix committed Jan 12, 2023
1 parent 8010723 commit 1edc104
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 13 deletions.
15 changes: 2 additions & 13 deletions lib/rack/bad_request.rb
@@ -1,15 +1,4 @@
module Rack
module BadRequest
class Middleware
def initialize(app)
@app = app
end

def call(env)
@app.call(env)
rescue BadRequest => error
[400, {}, ["Bad Request: #{error.message}"]]
end
end
end
module BadRequest
end
end
23 changes: 23 additions & 0 deletions lib/rack/error_handler.rb
@@ -0,0 +1,23 @@
module Rack
class ErrorHandler
def initialize(app)
@app = app
end

def bad_request(error)
[400, {}, ["Bad Request: #{error.message}"]]
end

def internal_server_error(error)
[500, {}, ["Internal Server Error: #{error.message}"]]
end

def call(env)
@app.call(env)
rescue BadRequest => error
return bad_request(error)
rescue => error
return internal_server_error(error)
end
end
end

0 comments on commit 1edc104

Please sign in to comment.