Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade macOS in Wheel CI #631

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Upgrade macOS in Wheel CI #631

merged 4 commits into from
Apr 18, 2024

Conversation

ikanago
Copy link
Contributor

@ikanago ikanago commented Apr 9, 2024

Upgrade macOS version from 12 in Wheel CI.
Since Python 3.8 and 3.9 is not available in macOS 14(arm runner), they are excluded.
And architecture option in setup-python is removed. Some options like arm64 does not exist, and the architecture is selected properly by default.

`brew upgrade` fails since XCode 15 is not available in macOS 12
Because the corresponding interpreters are not available
Copy link
Contributor

@KowerKoint KowerKoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@KowerKoint
Copy link
Contributor

KowerKoint commented Apr 12, 2024

Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

in the part of uploading artifacts.
I check the file name of wheel/*.whl ( https://github.com/qulacs/qulacs/actions/runs/8655428416 ) but they are all different. so I do not know why this is happening.

But downgrading actions/upload-artifact to @v3 resolves, it seems to be v4's error.

As of upload-artifact@v4, uploading files with the same name occurs error.
@ikanago
Copy link
Contributor Author

ikanago commented Apr 18, 2024

As of v4, uploading the same artifact name (not file name) leads an error.
Maintainer of the action says it is the expected behavior. ref:actions/upload-artifact#478 (comment)
So I named each artifact with Python version, OS and architecture so that they all have different names.

@ikanago ikanago merged commit 4bc1dc5 into main Apr 18, 2024
37 checks passed
@ikanago ikanago mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants