fix(udp): do not enable URO on Windows on ARM #2071
Merged
+62
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
force-pushed
the
no-uro-on-arm
branch
4 times, most recently
from
70ffc68 to
c958ab5
Compare
|
Given your involvement on #2041, @thomaseizinger @stormshield-damiend do you have thoughts? @valenting since you had the idea of using |
djc
reviewed
Nov 28, 2024
i am ok with this approach, this prevent issue for people that uses Windows ARM + WSL and gives us some time to understand the root cause. |
valenting
approved these changes
Nov 28, 2024
mxinden
force-pushed
the
no-uro-on-arm
branch
from
c958ab5 to
653e382
Compare
On Windows on ARM with Windows Subsystem for Linux (WSL) `WSA_RECVMSG` does not return the segment size of coalesced UDP datagrams. See quinn-rs#2041 for details. While lacking a fix for the root cause, don't enable URO, i.e. don't coalesce UDP datagrams on Windows on ARM.
mxinden
force-pushed
the
no-uro-on-arm
branch
from
653e382 to
4e23e95
Compare
thomaseizinger
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
I'll have to double check but I think the user that ran into this with Firezone was on x64.
Happy for this to merge regardless.
We could also consider adding a config option, defaulting to disabled and with a warning that it may not work on all systems.
I think I'd rather disable GRO completely for Firezone on Windows until we get to the bottom of this. Or add some kind of compatibility switch.
djc
approved these changes
Nov 29, 2024
|
@Ralith as the main author of |
|
Thanks everyone for the review. This pull request bumps the @djc @Ralith could either of you publish the new release? That way folks get the following bug fixes:
|
|
Will do it on Monday at the latest. |
|
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Dec 12, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 13, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505 UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 13, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505 UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 13, 2024
…chain-reviewers `quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see quinn-rs/quinn#2071. In addition `quinn-udp` `v0.5.8` Includes the following bugfixes: - quinn-rs/quinn#2072 - quinn-rs/quinn#2073 - quinn-rs/quinn#2074 - quinn-rs/quinn#2050 - quinn-rs/quinn#2047 Differential Revision: https://phabricator.services.mozilla.com/D231505 UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows on ARM with Windows Subsystem for Linux (WSL)
WSA_RECVMSGdoes not return the segment size of coalesced UDP datagrams. See #2041 for details.While lacking a fix for the root cause, don't enable URO, i.e. don't coalesce UDP datagrams, on Windows on ARM.