Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expect message to unwrap in PacketBuilder #1951

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Add expect message to unwrap in PacketBuilder #1951

merged 1 commit into from
Aug 1, 2024
+3 −1

Conversation

casey
Copy link
Contributor

@casey casey commented Aug 1, 2024

This unwrap can be hit by a bad custom Session implementation. Add the message suggested in #1928 give a hint as to what went wrong.

Fixes #1928.

@casey
Add expect message to unwrap in PacketBuilder

Verified

This commit was signed with the committer’s verified signature.
jglick Jesse Glick
GPG key ID: 1DDA69D94B624311
Verified
Learn about vigilant mode
7962e00
@casey casey mentioned this pull request Aug 1, 2024
Closed
@Ralith
Copy link
Collaborator

Ralith commented Aug 1, 2024

Thanks!

@djc djc added this pull request to the merge queue Aug 1, 2024
Merged via the queue into quinn-rs:main with commit da37b3b Aug 1, 2024
8 checks passed
@casey casey deleted the add-expect-message branch August 2, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith

@djc djc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding an expect message to unwrap in packet_builder.rs
3 participants
@casey @Ralith @djc