remove unneeded nil check for new connections in the server #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4260 +/- ##
==========================================
+ Coverage 84.06% 84.10% +0.04%
==========================================
Files 150 150
Lines 15425 15421 -4
==========================================
+ Hits 12966 12969 +3
+ Misses 1955 1950 -5
+ Partials 504 502 -2 ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't believe it's needed.
AddWithConnIDwill returnfalseif there's no connection.Furthermore,
conn.runwould have panicked with a nil pointer dereference anyway before we even hit thisnilcheck.