send the CONNECTION_REFUSED error when refusing a connection #4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, we used Connection.destroy, which destroys a connection without sending out a CONNECTION_CLOSE frame. This is useful (for example) when receiving a stateless reset, but it's not what we want when the server refuses an incoming connection. In this case, we want to send out a packet with a CONNECTION_CLOSE frame to inform the client that the connection attempt is being rejected.
marten-seemann
force-pushed
the
actually-send-connection-refused
branch
from
00933a8
to
2531ac6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4250 +/- ##
==========================================
- Coverage 84.11% 84.10% -0.01%
==========================================
Files 150 150
Lines 15398 15403 +5
==========================================
+ Hits 12951 12954 +3
- Misses 1946 1948 +2
Partials 501 501 ☔ View full report in Codecov by Sentry. |
marten-seemann
changed the title
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
…c-go#4250) So far, we used Connection.destroy, which destroys a connection without sending out a CONNECTION_CLOSE frame. This is useful (for example) when receiving a stateless reset, but it's not what we want when the server refuses an incoming connection. In this case, we want to send out a packet with a CONNECTION_CLOSE frame to inform the client that the connection attempt is being rejected.
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
…c-go#4250) So far, we used Connection.destroy, which destroys a connection without sending out a CONNECTION_CLOSE frame. This is useful (for example) when receiving a stateless reset, but it's not what we want when the server refuses an incoming connection. In this case, we want to send out a packet with a CONNECTION_CLOSE frame to inform the client that the connection attempt is being rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we used
Connection.destroy, which destroys a connection without sending out a CONNECTION_CLOSE frame. This is useful (for example) when receiving a stateless reset, but it's not what we want when the server refuses an incoming connection. In this case, we want to send out a packet with a CONNECTION_CLOSE frame to inform the client that the connection attempt is being rejected.This PR also adds an integration test. Once again this confirms the rule: If there's no test, it will break, rather sooner than later.