Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reject ClientHellos that offer TLS versions older than 1.3 (for Go 1.20) #4130

Merged
merged 1 commit into from Oct 25, 2023

Conversation

marten-seemann
Copy link
Member

Recreating #4129.

@marten-seemann marten-seemann added this to the v0.40 milestone Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4130 (63cd609) into master (746290b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   83.73%   83.74%   +0.02%     
==========================================
  Files         150      150              
  Lines       15429    15429              
==========================================
+ Hits        12918    12921       +3     
+ Misses       2012     2009       -3     
  Partials      499      499              

see 1 file with indirect coverage changes

Copy link
Collaborator

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0RTT approval 😆

@marten-seemann marten-seemann merged commit e2622bf into master Oct 25, 2023
34 checks passed
@marten-seemann marten-seemann deleted the clienthello-version-check2 branch October 27, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants