never allow 0-RTT when using Dial, even if the session ticket allows it #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
no-0rtt-on-dial
branch
from
13a8bca
to
1673a7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
==========================================
+ Coverage 83.74% 83.74% +0.01%
==========================================
Files 150 150
Lines 15421 15429 +8
==========================================
+ Hits 12913 12921 +8
Misses 2010 2010
Partials 498 498
|
marten-seemann
changed the base branch from
integration-tests-typed-atomics
to
master
marten-seemann
force-pushed
the
no-0rtt-on-dial
branch
from
d60c398
to
03df145
Compare
When resuming a TLS session using Dial (and not DialEarly), 0-RTT should be disabled at the TLS layer, even if the session ticket allows for 0-RTT resumption. This bug is not critical, since Dial doesn't return an EarlyConnection, so the client wouldn't be able to actually send 0-RTT data in practice.
marten-seemann
force-pushed
the
no-0rtt-on-dial
branch
from
03df145
to
0794d11
Compare
marten-seemann
force-pushed
the
no-0rtt-on-dial
branch
from
4f52dfd
to
0794d11
Compare
sukunrt
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4120.
When resuming a TLS session using Dial (and not DialEarly), 0-RTT should be disabled at the TLS layer, even if the session ticket allows for 0-RTT resumption.
This bug is not critical, since Dial doesn't return an EarlyConnection, so the client wouldn't be able to actually send 0-RTT data in practice.