Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use bash on all platforms #4122

Merged
merged 1 commit into from Oct 23, 2023
Merged

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4122 (4ec1ffe) into master (4c357c8) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4122      +/-   ##
==========================================
- Coverage   83.72%   83.61%   -0.10%     
==========================================
  Files         150      147       -3     
  Lines       15421    15104     -317     
==========================================
- Hits        12910    12629     -281     
+ Misses       2012     1992      -20     
+ Partials      499      483      -16     

see 6 files with indirect coverage changes

@marten-seemann
Copy link
Member Author

This doesn't work. Windows is just terrible. A pain in every regard.

@marten-seemann marten-seemann changed the title ci: fix setting of the QLOGFLAG env on Windows ci: use bash on all platforms Oct 23, 2023
@marten-seemann
Copy link
Member Author

@marten-seemann marten-seemann marked this pull request as ready for review October 23, 2023 06:36
@marten-seemann marten-seemann merged commit 7884f87 into master Oct 23, 2023
32 checks passed
@marten-seemann marten-seemann deleted the windows-fix-qlog-setting branch October 28, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant