Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create separate artifact archives per workflow run #4121

Merged
merged 1 commit into from Oct 23, 2023

Conversation

marten-seemann
Copy link
Member

Also reduces the retention time to 7 days. This is only used for debugging, so one week should be fine.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4121 (2057830) into master (36f7fe7) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4121      +/-   ##
==========================================
+ Coverage   83.74%   84.01%   +0.27%     
==========================================
  Files         150      146       -4     
  Lines       15421    15300     -121     
==========================================
- Hits        12913    12853      -60     
+ Misses       2010     1951      -59     
+ Partials      498      496       -2     

see 9 files with indirect coverage changes

@marten-seemann
Copy link
Member Author

marten-seemann commented Oct 23, 2023

Tested in https://github.com/quic-go/quic-go/actions/runs/6609176460?pr=4119:
image

Not sure why Windows doesn't produce any qlog files, but this is orthogonal to this PR.

@marten-seemann marten-seemann changed the title create separate artifact archives per workflow run ci: create separate artifact archives per workflow run Oct 23, 2023
@marten-seemann marten-seemann merged commit 4c357c8 into master Oct 23, 2023
32 checks passed
@marten-seemann marten-seemann deleted the separate-qlog-artifacts branch October 28, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant