Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch EPERM sendmsg errors for the very first packet on Linux #4111

Merged
merged 1 commit into from Oct 17, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Oct 13, 2023

This is a workaround for golang/go#63322. On Linux, we now ignore the EPERM error for the very first sendmsg call on a new connection, and retry exactly once.

This is expected to dramatically reduce the flakiness of our test suite.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #4111 (86de97c) into master (49e588a) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
+ Coverage   83.71%   83.73%   +0.02%     
==========================================
  Files         150      150              
  Lines       15401    15415      +14     
==========================================
+ Hits        12892    12907      +15     
+ Misses       2010     2009       -1     
  Partials      499      499              
Files Coverage Δ
send_conn.go 88.68% <88.89%> (+1.72%) ⬆️
sys_conn_helper_linux.go 76.12% <83.33%> (+0.71%) ⬆️
sys_conn_helper_nonlinux.go 20.00% <0.00%> (-5.00%) ⬇️

... and 1 file with indirect coverage changes

@marten-seemann marten-seemann added this to the v0.40 milestone Oct 13, 2023
@marten-seemann marten-seemann force-pushed the linux-catch-sendmsg-eperm branch 3 times, most recently from 65048f9 to 84ffb94 Compare October 13, 2023 06:49
send_conn.go Show resolved Hide resolved
@marten-seemann marten-seemann merged commit b344940 into master Oct 17, 2023
32 checks passed
@marten-seemann marten-seemann deleted the linux-catch-sendmsg-eperm branch October 21, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants