Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't spawn a new Go routine to send a CONNECTION_REFUSED packet #4091

Merged
merged 1 commit into from Sep 25, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Sep 17, 2023

Depends on #4090.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #4091 (f766bf1) into master (9a397ab) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 55.56%.

❗ Current head f766bf1 differs from pull request most recent head eb99dd5. Consider uploading reports for the commit eb99dd5 to get more accurate results

@@            Coverage Diff             @@
##           master    #4091      +/-   ##
==========================================
- Coverage   83.74%   83.72%   -0.02%     
==========================================
  Files         150      150              
  Lines       15394    15378      -16     
==========================================
- Hits        12891    12875      -16     
- Misses       2003     2005       +2     
+ Partials      500      498       -2     
Files Changed Coverage Δ
server.go 76.83% <55.56%> (+0.49%) ⬆️

... and 4 files with indirect coverage changes

@marten-seemann marten-seemann changed the base branch from simplify-invalid-token-sending to master September 25, 2023 09:14
@marten-seemann marten-seemann merged commit ae2ef95 into master Sep 25, 2023
16 checks passed
@marten-seemann marten-seemann deleted the connection-refused-go-routine branch September 25, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants