use new gomock feature to generate type-safe methods in mocks #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
gomock-type-safe
branch
2 times, most recently
from
8bc3bf6
to
93d81fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #4057 +/- ##
=======================================
Coverage 83.71% 83.71%
=======================================
Files 150 150
Lines 15415 15415
=======================================
Hits 12904 12904
Misses 2012 2012
Partials 499 499 |
marten-seemann
force-pushed
the
gomock-type-safe
branch
2 times, most recently
from
6fb5f34
to
5194bdd
Compare
|
Tests are failing due to uber-go/mock#80 and uber-go/mock#81. |
marten-seemann
force-pushed
the
gomock-type-safe
branch
from
6f13788
to
c7bbc9e
Compare
This was referenced Sep 13, 2023
marten-seemann
force-pushed
the
gomock-type-safe
branch
from
c7bbc9e
to
7f25ef1
Compare
|
Updated after bumping gomock to v0.3.0. CI seems happy. |
marten-seemann
force-pushed
the
gomock-type-safe
branch
from
7f25ef1
to
9405e6c
Compare
sukunrt
approved these changes
Oct 17, 2023
marten-seemann
force-pushed
the
gomock-type-safe
branch
from
9405e6c
to
dc1c9f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.